mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56053: Added a 'SECRET' type to the 'Environment' protobuf message.
Date Thu, 09 Feb 2017 18:17:34 GMT


> On Feb. 9, 2017, 9:50 a.m., Adam B wrote:
> > LGTM, but you're mostly just updating the tests to uses VALUE, and there's only
a single test for the REFERENCE type. Is there nothing else we should test there?
> 
> Greg Mann wrote:
>     Since we haven't actually implemented the passing of secrets into environments yet,
validation tests are sufficient at the moment. My rationale for including just one REFERENCE-type
test was that since all of these validation routines call into a common validation helper
for `CommandInfo`:
>     * validating a single secret type in all relevant protos ensures that the common
validation helper is being called in each case
>     * validating the REFERENCE type in just one proto is sufficient to ensure that the
common helper validates that secret type correctly
>     
>     We could validate all types in all cases, but I erred on the side of less test code
which accomplishes sufficient coverage. What do you think?

This is a bit more brittle, since changes to the validation implementation could poke holes
in the testing coverage later.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56053/#review164887
-----------------------------------------------------------


On Feb. 9, 2017, 6:34 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56053/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 6:34 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Kapil Arya, Jan Schlicht, and Vinod Kone.
> 
> 
> Bugs: MESOS-7009
>     https://issues.apache.org/jira/browse/MESOS-7009
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a field of type `Secret` to the
> `Environment` protobuf message, enabling the passing
> of secrets into the environments of executors and
> tasks. Additional validation and test code is added
> as well.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 34a288b6f5c2fca090a7aa7a61798e3255d6663a 
>   include/mesos/v1/mesos.proto 6638111d10f4a36cdf91dfce1019871e9839c306 
>   src/common/validation.cpp 0f1a02286d8431acfee6136e8ada49b0ac746897 
>   src/tests/check_tests.cpp b5a5d8e80c80b480992a3c8160ee7d0e4443111c 
>   src/tests/health_check_tests.cpp 7b6a803a28b2e4f6c27e9a0c4f668350ec2d5a81 
>   src/tests/master_validation_tests.cpp 0c2649089d7fd29eb021ac75c71e6a74368577dc 
>   src/tests/slave_validation_tests.cpp 3d17799ed04951fb56524db0f5d89347192300b2 
> 
> Diff: https://reviews.apache.org/r/56053/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message