mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 56465: Add support for the ELF .interp section.
Date Thu, 09 Feb 2017 18:33:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56465/#review164876
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/elf.hpp (line 215)
<https://reviews.apache.org/r/56465/#comment236790>

    Nit: s/section// to be consistent with the error messages in `get_*`s.


- Jiang Yan Xu


On Feb. 9, 2017, 9:20 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56465/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 9:20 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7060
>     https://issues.apache.org/jira/browse/MESOS-7060
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add support for the ELF .interp section.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/elf.hpp 2bf91a0c5ea0b0cac74a844345b0ce13777f1edb 
> 
> Diff: https://reviews.apache.org/r/56465/diff/
> 
> 
> Testing
> -------
> 
> make check (Fedora, Ubuntu)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message