mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.
Date Thu, 09 Feb 2017 18:56:40 GMT


> On Feb. 9, 2017, 6:55 p.m., Andrew Schwartzmeyer wrote:
> > Ship It!

(But it might have some repercussions. It looks like the default use of `mktemp()` is now
changing from `/tmp` (correct on Linux, incorrect on Windows), to `.` (current folder, working
anywhere, but "correct" nowhere).


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56504/#review164968
-----------------------------------------------------------


On Feb. 9, 2017, 5:57 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56504/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 5:57 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Made `os::mktemp` fully cross-platform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/mktemp.hpp 231234f7652937e042f49b13fe8fc3c7193d26e1

> 
> Diff: https://reviews.apache.org/r/56504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message