mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 56466: Capture ELF interpreters in the ldd utility.
Date Thu, 09 Feb 2017 19:33:35 GMT


> On Feb. 9, 2017, 7:21 p.m., Jiang Yan Xu wrote:
> > src/linux/ldd.cpp, lines 85-88
> > <https://reviews.apache.org/r/56466/diff/3/?file=1628611#file1628611line85>
> >
> >     I suggest the following and can do it while committing but let me know if there's
an error in it.
> >     
> >     ```
> >           // If this ELF object has an interpreter (e.g. ld-linux-x86-64.so.2),

> >           // inspect that too. We need both to be able to run an executable program.
> >           // NOTE: The same object may be specified as a dependency too but on some
> >           // systems (e.g. Ubuntu), the exact path of the two can differ even though
> >           // they link to the the same file (see MESOS-7060). We however need the
> >           // exact path specified in the interpreter section to run the executable.
> >     ```

I agree that this is an improvement. Thanks!


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56466/#review164984
-----------------------------------------------------------


On Feb. 9, 2017, 5:21 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56466/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 5:21 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7060
>     https://issues.apache.org/jira/browse/MESOS-7060
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The ELF interpreter (ie. program loader) path is not necessarily
> specified in the ELF dependencies section but we still need
> to capture is as a dependency of an executable program.
> 
> 
> Diffs
> -----
> 
>   src/linux/ldd.cpp dd5c9c55560dc2895763141393fdaf97be66a5a8 
> 
> Diff: https://reviews.apache.org/r/56466/diff/
> 
> 
> Testing
> -------
> 
> make check (Fedora, Ubuntu)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message