mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56499: Added roles field to framework.
Date Thu, 09 Feb 2017 21:38:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56499/#review165008
-----------------------------------------------------------



Thanks! We need to ensure we update this field when updating the framework info (see comment
below).

Also, since we can construct this via the FrameworkInfo, we don't need to take this as a constructor
argument to the framework struct, since this just introduces the potential for a caller to
get this wrong.


src/master/master.hpp (line 2163)
<https://reviews.apache.org/r/56499/#comment236831>

    No need to pass it as an argument, we can just construct it from the already provided
FrameworkInfo.



src/master/master.hpp (lines 2425 - 2451)
<https://reviews.apache.org/r/56499/#comment236835>

    We need to update the newly introduced `roles` field here. Also, oldRoles can be removed
in favor of directly accessing `roles`.



src/master/master.cpp (lines 2548 - 2553)
<https://reviews.apache.org/r/56499/#comment236832>

    No change needed here, since we can just construct the roles based on the framework info.



src/master/master.cpp (lines 2842 - 2847)
<https://reviews.apache.org/r/56499/#comment236833>

    Ditto here, no change needed.



src/master/master.cpp (lines 7475 - 7479)
<https://reviews.apache.org/r/56499/#comment236834>

    Ditto here, no change needed.


- Benjamin Mahler


On Feb. 9, 2017, 3:50 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56499/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 3:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jay Guo.
> 
> 
> Bugs: MESOS-6638
>     https://issues.apache.org/jira/browse/MESOS-6638
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added roles field to framework.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 767ac48f2a65514a19c4a3f8ca7b35f0259f9aeb 
>   src/master/master.cpp 620919ecfe85367b5c1281afc5216cc20e5e2e3c 
> 
> Diff: https://reviews.apache.org/r/56499/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message