mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 56366: Windows: Refactor executor to use `SharedHandle` semantics.
Date Fri, 10 Feb 2017 00:29:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56366/#review165030
-----------------------------------------------------------




src/launcher/windows/executor.cpp (lines 105 - 119)
<https://reviews.apache.org/r/56366/#comment236870>

    Hm.  The code duplication between here and the WindowsLauncher makes me think that we
should move JobObject creation/management to a libprocess actor of some sort.
    
    It would be logically similar to the WindowsLauncher, but have a lifecycle like the `ReaperProcess`.
 It would also need to be Windows-only.


- Joseph Wu


On Feb. 8, 2017, 1:16 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56366/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 1:16 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-6892
>     https://issues.apache.org/jira/browse/MESOS-6892
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The executor now owns the `SharedHandle` for the process and job object,
> so that their lifetime is correctly tied to the executor and their
> handles will be closed properly.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9 
>   src/launcher/windows/executor.hpp 6f02912c477105819b4c27ddf248b7289799eaa0 
>   src/launcher/windows/executor.cpp b51fde7376c2083119f342ea599b446944ede000 
> 
> Diff: https://reviews.apache.org/r/56366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message