mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 56209: Hashed unacknowledged updates by UUID string in command executor.
Date Fri, 10 Feb 2017 00:47:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56209/#review165036
-----------------------------------------------------------



Sorry I don't follow the argument for this change. Still looks weird to me. We don't do this
anywhere else in the code (master, agent, status update manager). Hashing by UUID seems more
intuitive to me.

- Vinod Kone


On Feb. 8, 2017, 4:56 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56209/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 4:56 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update acknowledgements contain UUID as string, a conversion is
> anyway necessary. In the future we may not have access to the
> original UUID, while string representation is always available in
> the protobuf message itself. Hence it seems reasonable to hash
> updates by string instead of UUID.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969 
> 
> Diff: https://reviews.apache.org/r/56209/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56218/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message