mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Review Request 56530: Prevent offers for old agents being sent to MULTI_ROLE frameworks.
Date Fri, 10 Feb 2017 06:10:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56530/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.


Bugs: MESOS-6940
    https://issues.apache.org/jira/browse/MESOS-6940


Repository: mesos


Description
-------

In a mixed cluster, when an old agent (not MULTI_ROLE capable)
registers with new master (MULTI_ROLE capable), it cannot correctly
handle tasks from a MULTI_ROLE framework. Therefore, we should
disallow offers from these agents being sent to MULTI_ROLE frameworks.


Diffs
-----

  src/master/master.cpp 620919ecfe85367b5c1281afc5216cc20e5e2e3c 
  src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18 

Diff: https://reviews.apache.org/r/56530/diff/


Testing
-------

WIP

./bin/mesos-tests.sh --gtest_filter="MasterTest.MultiRoleFrameworkDoesNotReceiveOfferFromOldAgent"
--gtest_break_on_failure --gtest_repeat=-1


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message