mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 52284: Implemented more quota validation tests and validate duplicate name.
Date Mon, 13 Feb 2017 16:37:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52284/#review165352
-----------------------------------------------------------



Thanks for adding validation of the error messages.

Currently you output the response body should it not have the right status code. I think the
following would make more sense:

    AWAIT_EXPECT_RESPONSE_STATUS_EQ(BadRequest().status, response);

    AWAIT_EXPECT_RESPONSE_BODY_EQ(
        "Failed to validate set quota request: QuotaInfo may not contain same "
        "resource name twice",
        response)
      << response.get().body;

- Benjamin Bannier


On Feb. 10, 2017, 8:54 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52284/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2017, 8:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Xiaojian Huang, and Neil Conway.
> 
> 
> Bugs: MESOS-4292
>     https://issues.apache.org/jira/browse/MESOS-4292
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented more quota validation tests and validate duplicate name.
> 
> 
> Diffs
> -----
> 
>   src/master/quota.cpp 847ec068f4f3fe94ddabc11ff583d7e76117d375 
>   src/tests/master_quota_tests.cpp d15c7aacb85596cdee7cf59c0c179247ba624fe5 
> 
> Diff: https://reviews.apache.org/r/52284/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message