mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 56771: Added regression test against fetcher SSL spillover.
Date Wed, 22 Feb 2017 01:16:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56771/#review166187
-----------------------------------------------------------


Fix it, then Ship it!




Looks good to me. Just a cuminor comments.


src/tests/fetcher_tests.cpp (line 1112)
<https://reviews.apache.org/r/56771/#comment238063>

    Maybe at least choose different strings for dirname and path?



src/tests/fetcher_tests.cpp (line 1135)
<https://reviews.apache.org/r/56771/#comment238203>

    Seems like this AWAIT is the final check. Please add a comment explaining how a successful
fetch means a successful test run.


- Adam B


On Feb. 21, 2017, 7:56 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56771/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2017, 7:56 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added regression test against fetcher SSL spillover.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_tests.cpp 9c7e8b94071501c435e26850d66a8f3e8950c6cd 
> 
> Diff: https://reviews.apache.org/r/56771/diff/
> 
> 
> Testing
> -------
> 
> Before applying RR56711:
> ```
> [ RUN      ] FetcherTest.EnvironmentSpillover
> W0216 23:31:25.794740 124055552 fetcher.cpp:899] Begin fetcher log (stderr in sandbox)
for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9 from running command: /Users/till/Development/mesos-private/build/src/mesos-fetcher
> I0216 23:31:25.746598 3022980032 fetcher.cpp:531] Fetcher Info: {"cache_directory":"\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/mesos\/fetch\/slaves\/","items":[{"action":"BYPASS_CACHE","uri":{"extract":true,"value":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM\/Fo2V66\/zpbEP1.gz"}}],"sandbox_directory":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM"}
> I0216 23:31:25.752025 3022980032 fetcher.cpp:442] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.752058 3022980032 fetcher.cpp:283] Fetching directly into the sandbox
directory
> I0216 23:31:25.752096 3022980032 fetcher.cpp:220] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.756001 3022980032 fetcher.cpp:205] Copied resource '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
to '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/zpbEP1.gz'
> SSL requires key! NOTE: Set path with LIBPROCESS_SSL_KEY_FILE
> 
> End fetcher log for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9
> E0216 23:31:25.795078 124055552 fetcher.cpp:555] Failed to run mesos-fetcher: Failed
to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
> ../../src/tests/fetcher_tests.cpp:1134: Failure
> (fetch).failure(): Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9'
with exit status: 256
> [  FAILED  ] FetcherTest.EnvironmentSpillover (115 ms)
> ```
> 
> After applying RR56711:
> ```
> [ RUN      ] FetcherTest.EnvironmentSpillover
> [       OK ] FetcherTest.EnvironmentSpillover (300 ms)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message