mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 56830: Introduced `TaskInfo::OnTerminationPolicy` protobuf.
Date Wed, 22 Feb 2017 18:16:32 GMT


> On Feb. 21, 2017, 9:50 p.m., Vinod Kone wrote:
> > include/mesos/mesos.proto, line 1581
> > <https://reviews.apache.org/r/56830/diff/1/?file=1640428#file1640428line1581>
> >
> >     also for unknown status (e.g., OOM)
> 
> Jiang Yan Xu wrote:
>     Since Mesos never defined tasks as processes only, It's whatever the executor decides,
I think it's fine to not define it directly here but rather refer to `TASK_FAILED`. i.e.,
however TASK_FAILED is defined.
>     
>     Would this be clear:
>     
>     ```
>     // The task group would be only killed when the task failed,
>     // i.e., it will be transitioned to TASK_FAILED state.
>     ```

Fair enough. Clarified comments specifically for the default executor case.


> On Feb. 21, 2017, 9:50 p.m., Vinod Kone wrote:
> > include/mesos/mesos.proto, line 1558
> > <https://reviews.apache.org/r/56830/diff/1/?file=1640428#file1640428line1558>
> >
> >     s/On//
> 
> Jiang Yan Xu wrote:
>     I think `OnTerminationPolicy` looks ugly not because of `On` but rather it's a three
word term which is a bit mouthful. `OnTermination` or `OnTerminate` by itself is widely used
in similar contexts. I started to wonder if the word `Policy` add much additional info. The
protobuf is clearly about how to **handle** (i.e., **action** to take on) termination. Maybe
none of these words are necessary?

hmm, `OnTermination` and `OnTerminate` look more like handler names and hence not quite suitable.
I think it's fine to use `TerminationPolicy` here while being explicit in the comments to
dissambiguate it.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56830/#review166233
-----------------------------------------------------------


On Feb. 20, 2017, 5 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56830/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2017, 5 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7067
>     https://issues.apache.org/jira/browse/MESOS-7067
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Describes the on termination policy associated with a task and is
> applied upon a task termination.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d 
>   include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574 
> 
> Diff: https://reviews.apache.org/r/56830/diff/
> 
> 
> Testing
> -------
> 
> make check (tests later in the chain)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message