mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 56212: Added support for general checks to command executor.
Date Tue, 28 Feb 2017 15:13:08 GMT


> On Feb. 14, 2017, 6:59 p.m., Gastón Kleiman wrote:
> > src/launcher/executor.cpp, lines 848-854
> > <https://reviews.apache.org/r/56212/diff/3/?file=1627706#file1627706line848>
> >
> >     This method is called to build updates when the task transitions to `TASK_KILLING`,
`TASK_FINISHED`, `TASK_KILLED`, and `TASK_FAILED`.
> >     
> >     Do we want to lose the result of the previous check in all those cases? I think
it might make sense to keep it at least for `TASK_KILLING`. It would also make sense to keep
the `health` flag in that case.

I'm not sure what is the best thing to do here. Does it make sense to talk about check status
when, e.g., the task is being killed?

Moreover, for health checks, keeping health info for terminal states means changing current
behaviour.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56212/#review165550
-----------------------------------------------------------


On Feb. 8, 2017, 4:56 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56212/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 4:56 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969 
> 
> Diff: https://reviews.apache.org/r/56212/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56218/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message