mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 57161: Cleaned up header includes.
Date Wed, 01 Mar 2017 00:16:59 GMT


> On March 1, 2017, 12:04 a.m., Michael Park wrote:
> > src/linux/capabilities.cpp, line 23
> > <https://reviews.apache.org/r/57161/diff/1/?file=1651961#file1651961line23>
> >
> >     I don't think we need this?

We use `std::set` in that `.cpp` file. (We previously had `using std::set;` as well, but I
removed it, because it is confusing with the `set` member functions implemented by that file.)


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57161/#review167183
-----------------------------------------------------------


On Feb. 28, 2017, 8:07 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57161/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 8:07 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up header includes.
> 
> 
> Diffs
> -----
> 
>   src/linux/capabilities.hpp 7c6342745a7db1ecf8664c64be77b10a54d5037a 
>   src/linux/capabilities.cpp 9f46bd0a34d35d8295b1899a7ba67d85c3c24348 
> 
> Diff: https://reviews.apache.org/r/57161/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message