mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 57121: Renamed 'ContainerLogger::SubprocessInfo' to 'ContainerIO'.
Date Wed, 01 Mar 2017 01:38:27 GMT


> On Feb. 28, 2017, 10:19 p.m., Jie Yu wrote:
> > include/mesos/slave/container_logger.hpp, line 58
> > <https://reviews.apache.org/r/57121/diff/1/?file=1650926#file1650926line58>
> >
> >     I would pull this to top level, rather than nested inside container logger as
it'll be used by io switchboard as well.
> >     
> >     Probably put that in `include/mesos/slave/containerizer.hpp`

I think I'd rather do this as a follow-on patch to https://reviews.apache.org/r/56195. Otherwise
we will have to compress all of these patches into 1 because the nee 'ContainerIO' class will
conflict with the 'ContainerIO' protobuf definition (which we remove in 56195).

Sound good?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57121/#review167143
-----------------------------------------------------------


On Feb. 28, 2017, 5:09 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57121/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 5:09 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Bugs: MESOS-7050
>     https://issues.apache.org/jira/browse/MESOS-7050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed 'ContainerLogger::SubprocessInfo' to 'ContainerIO'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp a3f619b79ca0188df9e231c600dfa396f39ab29a 
>   src/slave/container_loggers/lib_logrotate.hpp e37d99cb268bb3286e312d2ebdbaf84d3fd4bf91

>   src/slave/container_loggers/lib_logrotate.cpp b257f48f819985e339a5a7fd8066ffa9f39df7a6

>   src/slave/container_loggers/sandbox.hpp 4ec090cbfc5834ead45ec39c3a646f491fe892cb 
>   src/slave/container_loggers/sandbox.cpp b55e089877f205bab482ae4ebe5a2010aeebeb47 
>   src/slave/containerizer/docker.cpp 7d801fb17565a5298e8e3c5b430e070e12473680 
>   src/slave/containerizer/mesos/io/switchboard.hpp 5b1fa25d5f577ce3c232fdf5324c7f9c837a64ce

>   src/slave/containerizer/mesos/io/switchboard.cpp 820d53bc12b1bf6018132660e4b7c5eae8c1e2ee

>   src/tests/container_logger_tests.cpp 589d6a9df7ce964052355be41597ef11677ca03d 
> 
> Diff: https://reviews.apache.org/r/57121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message