mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 57176: Pulled 'ContainerIO' out of the 'ContainerLogger'.
Date Wed, 01 Mar 2017 01:51:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57176/#review167195
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On March 1, 2017, 1:43 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57176/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 1:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7050
>     https://issues.apache.org/jira/browse/MESOS-7050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Pulled 'ContainerIO' out of the 'ContainerLogger'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp a3f619b79ca0188df9e231c600dfa396f39ab29a 
>   include/mesos/slave/containerizer.hpp d0096b9e0478478cc8184b1ea6bfecafb1a8620f 
>   src/slave/container_loggers/lib_logrotate.hpp e37d99cb268bb3286e312d2ebdbaf84d3fd4bf91

>   src/slave/container_loggers/lib_logrotate.cpp b257f48f819985e339a5a7fd8066ffa9f39df7a6

>   src/slave/container_loggers/sandbox.hpp 4ec090cbfc5834ead45ec39c3a646f491fe892cb 
>   src/slave/container_loggers/sandbox.cpp b55e089877f205bab482ae4ebe5a2010aeebeb47 
>   src/slave/containerizer/docker.cpp 7d801fb17565a5298e8e3c5b430e070e12473680 
>   src/slave/containerizer/mesos/containerizer.hpp 10a9b57660388ac2409458a4d07af64cc3b185e2

>   src/slave/containerizer/mesos/containerizer.cpp d2b4f75a55dbe4746bc2dfc180335fa831a554ef

>   src/slave/containerizer/mesos/io/switchboard.hpp 5b1fa25d5f577ce3c232fdf5324c7f9c837a64ce

>   src/slave/containerizer/mesos/io/switchboard.cpp 820d53bc12b1bf6018132660e4b7c5eae8c1e2ee

>   src/tests/container_logger_tests.cpp 589d6a9df7ce964052355be41597ef11677ca03d 
> 
> Diff: https://reviews.apache.org/r/57176/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check
> src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message