mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error.
Date Wed, 01 Mar 2017 08:03:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53666/#review167233
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53666]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 28, 2017, 11:16 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53666/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 11:16 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6489
>     https://issues.apache.org/jira/browse/MESOS-6489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a `continueOnError` attribute to cgroups `Destroyer` to allow
> cgroups cleanup to continue incase of any error. The linux launcher
> continues cleanup of cgroups even if there is an error. However, if
> the top level cgroup is actually removed, it treats it as a success.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d 
>   src/linux/cgroups.cpp 3a853297eaccc86e55888da21f292f5e37c88733 
>   src/slave/containerizer/mesos/linux_launcher.cpp a3409dc64435e002072b9b458a5fda0564214f28

> 
> 
> Diff: https://reviews.apache.org/r/53666/diff/2/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message