mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 57165: Minor cleanup for quota validation code.
Date Wed, 01 Mar 2017 10:17:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57165/#review167247
-----------------------------------------------------------


Fix it, then Ship it!





src/master/quota.cpp
Line 147 (original), 142 (patched)
<https://reviews.apache.org/r/57165/#comment239400>

    How about: "Check that `resource` does not contain fields irrelevant for quota."?


- Benjamin Bannier


On Feb. 28, 2017, 9:18 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57165/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 9:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Minor cleanup for quota validation code.
> 
> 
> Diffs
> -----
> 
>   src/master/quota.cpp 847ec068f4f3fe94ddabc11ff583d7e76117d375 
> 
> 
> Diff: https://reviews.apache.org/r/57165/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message