mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 56213: Added check tests for command executor.
Date Wed, 01 Mar 2017 11:10:21 GMT


> On Feb. 15, 2017, 1:41 p.m., Gastón Kleiman wrote:
> > src/tests/check_tests.cpp
> > Lines 632 (patched)
> > <https://reviews.apache.org/r/56213/diff/3/?file=1627707#file1627707line632>
> >
> >     I'd add:
> >     
> >     ```
> >     EXPECT_FALSE(updateTaskRunning->status().has_healthy());
> >     
> >     EXPECT_TRUE(updateTaskRunning->status().has_check_status());
> >     EXPECT_TRUE(updateTaskRunning->status().check_status().has_command());
> >     EXPECT_FALSE(updateTaskRunning->status().check_status().command().has_exit_code());
> >     ```

I'd rather not. I would like to check that one does not shadow the other, hence
1) we probably don't want to make assumptions about how inital health is delivered here (btw,
this is something we need to change)
2) repeat checking initial check status (done in `CommandCheckDeliveredAndReconciled`).


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56213/#review165568
-----------------------------------------------------------


On Feb. 28, 2017, 3:55 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56213/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 3:55 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/check_tests.cpp b5a5d8e80c80b480992a3c8160ee7d0e4443111c 
>   src/tests/mesos.hpp b450a04dfbf3bbeeb6b605fb78097dca390cbdbe 
> 
> 
> Diff: https://reviews.apache.org/r/56213/diff/3/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56218/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message