mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.
Date Wed, 01 Mar 2017 16:15:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55887/
-----------------------------------------------------------

(Updated March 1, 2017, 4:15 p.m.)


Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.


Changes
-------

Moved the unschedule logic ahead of authorization of tasks.


Bugs: MESOS-6953
    https://issues.apache.org/jira/browse/MESOS-6953


Repository: mesos


Description
-------

Added support for action `run_tasks` on the agent's flag `acl`. Based on
the ACL configured for `run_tasks`, a task to be launched on the agent
can be (dis)allowed to launch on the agent.
If a task or task group cannot be launched due to failed authorization,
a `TASK_ERROR` Status Update shall be sent with a reason code of
`REASON_TASK_UNAUTHORIZED` or `REASON_TASK_GROUP_UNAUTHORIZED` as
applicable.
Note that in case of a task group, all tasks fail if any of the tasks
within the task group encounter the authorization error.


Diffs (updated)
-----

  src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2 
  src/slave/slave.cpp 892ce1938ac695e7913aa9139536d0787f3f5ea7 
  src/tests/master_slave_reconciliation_tests.cpp 1c7a3d686e2f924ad14c75fcab2ccafaab6d7b81

  src/tests/mock_slave.hpp 1acb961b642e1e0b4677db7b8fc6150d480eb751 
  src/tests/mock_slave.cpp 50c04bff9e6f0f202af4c07b4036e021d3833ebf 
  src/tests/slave_tests.cpp 3731c7607d5e49f3000c4863b1999851fac45705 


Diff: https://reviews.apache.org/r/55887/diff/6/

Changes: https://reviews.apache.org/r/55887/diff/5-6/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message