mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 53702: Added a factory method to produce PIDGroup.
Date Wed, 01 Mar 2017 18:37:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53702/#review167462
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 4:01 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53702/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 4:01 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
>     https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In the case of PIDGroup module, base pid may not be available at
> construction time, so base pid needs to be initialized after PIDGroup
> construction, but before PIDGroup being passed to LogProcess
> constructor, since PIDGroup is a const member in the form of Shared<>.
> Therefore, a factory method `createPIDGroup` is added to LogProcess.
> 
> To unify the implementation, we refactor ZooKeeperPIDGroup to be
> created by factory method as well. This is step toward modularizing
> PIDGroup interfaces.
> 
> 
> Diffs
> -----
> 
>   src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 
>   src/log/log.cpp 2301eef564f2a42958c6c2c8eef0cc4b2fd76353 
>   src/log/pid_group/zookeeper.hpp PRE-CREATION 
>   src/log/pid_group/zookeeper.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/53702/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message