mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 50493: Added `base` to PIDGroup.
Date Wed, 01 Mar 2017 18:38:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50493/#review167466
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 3:33 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50493/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 3:33 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
>     https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> All subclasses derived from PIDGroup are required to have `base`
> as a set of PIDs that always exist from the beginning. Therefore
> `base` is refactored into PIDGroup base class. This is a step
> towards modularizing replicated_log's PIDGroup abstraction.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/pid_group.hpp PRE-CREATION 
>   3rdparty/libprocess/src/pid_group.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50493/diff/5/
> 
> 
> Testing
> -------
> 
> see end of review chain
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message