mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 56208: Updated checks library with general check support.
Date Wed, 01 Mar 2017 20:23:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56208/#review167557
-----------------------------------------------------------




src/checks/checker.cpp
Line 297 (original), 309 (patched)
<https://reviews.apache.org/r/56208/#comment239434>

    Just do EXIT or LOG(FATAL), doing a CHECK that obviously fails is weird.
    
    ```
    LOG(FATAL) << "Received UNKNOWN check type";
    ```



src/checks/checker.cpp
Line 315 (original), 328 (patched)
<https://reviews.apache.org/r/56208/#comment239435>

    we should probably have a "<<" operator overload for check type.



src/checks/checker.cpp
Lines 398 (patched)
<https://reviews.apache.org/r/56208/#comment239440>

    can you add a comment on why you need to do a copy here?



src/checks/checker.cpp
Line 424 (original), 440 (patched)
<https://reviews.apache.org/r/56208/#comment239446>

    why are we sending WEXITSTATUS and not exit code?



src/checks/checker.cpp
Lines 499 (patched)
<https://reviews.apache.org/r/56208/#comment239443>

    ditto. comment here.


- Vinod Kone


On March 1, 2017, 12:50 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56208/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 12:50 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add support for general checks, i.e. defined by CheckInfo, in
> checking library. A general check can be either an command or
> an HTTP request. The library performs the requested check at
> the specified interval and sends the result to the framework
> via a task status update. If the current result is the same as
> the previous result, no status update is sent.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.hpp dc293f3d3613dec716510d269829f8a6f406c277 
>   src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 
>   src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 
>   src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1 
> 
> 
> Diff: https://reviews.apache.org/r/56208/diff/7/
> 
> 
> Testing
> -------
> 
> https://reviews.apache.org/r/56213/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message