mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57194: Updated WebUI to display role information under tab 'Offers'.
Date Wed, 01 Mar 2017 22:08:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57194/#review167583
-----------------------------------------------------------


Fix it, then Ship it!





src/webui/master/static/offers.html
Lines 17 (patched)
<https://reviews.apache.org/r/57194/#comment239487>

    I would suggest moving this up to be in front of the framework ID since allocations are
made primarily to roles.
    
    Also, I think you need a s/role/allocation_info.role/ here for the sorting to work correctly,
did you test the sorting?


- Benjamin Mahler


On March 1, 2017, 10:33 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57194/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 10:33 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6657
>     https://issues.apache.org/jira/browse/MESOS-6657
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated WebUI to display role information under tab 'Offers'.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/offers.html 181fc2deabef3faec36785e7fcdbc37465668bec 
> 
> 
> Diff: https://reviews.apache.org/r/57194/diff/1/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Page Offers
>   https://reviews.apache.org/media/uploaded/files/2017/03/01/4ffb17d5-12f0-4b5b-abab-f5b8133f53ca__Screen_Shot_2017-03-01_at_18.32.20.png
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message