mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`.
Date Wed, 01 Mar 2017 23:18:11 GMT


> On Feb. 27, 2017, 6:42 p.m., Benjamin Mahler wrote:
> > src/messages/messages.proto
> > Lines 574-575 (patched)
> > <https://reviews.apache.org/r/57106/diff/1/?file=1650757#file1650757line574>
> >
> >     Just one thing, looking at the subsequent patch, it appears that the agent updates
the entire framework info, not just capabilities. So let's remove this TODO? Is there anything
you want to call out here that won't be updated correctly by the agent if it were to change?

Oh, you're right. No, I don't think I have anything to call out here.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57106/#review166992
-----------------------------------------------------------


On Feb. 27, 2017, 2:11 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57106/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 2:11 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6627
>     https://issues.apache.org/jira/browse/MESOS-6627
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Taken verbatim from the [design doc](https://docs.google.com/document/d/1n0ZtRL49m3qpAeB4beEEhjTXQS-nYAbgRG9g44fn4WY).
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698 
> 
> 
> Diff: https://reviews.apache.org/r/57106/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message