mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 57166: Updated role validation for hierarchical roles.
Date Thu, 02 Mar 2017 01:21:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57166/#review167623
-----------------------------------------------------------




src/common/roles.cpp
Line 71 (original), 71 (patched)
<https://reviews.apache.org/r/57166/#comment239529>

    Why can't role start with a slash? According to the design doc, it seems the role like
`/eng/frontend` is valid.



src/common/roles.cpp
Lines 83 (patched)
<https://reviews.apache.org/r/57166/#comment239533>

    Kill this blank line.



src/common/roles.cpp
Line 82 (original), 95 (patched)
<https://reviews.apache.org/r/57166/#comment239549>

    s/Roles/Role/


- Qian Zhang


On March 1, 2017, 4:23 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57166/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 4:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Role names can now contain forward slashes. Each component in a role
> name must now be validated separately.
> 
> 
> Diffs
> -----
> 
>   src/common/roles.cpp 31774a9b8f99f5efeed35b1c3e3486e05ca00f6a 
>   src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 
> 
> 
> Diff: https://reviews.apache.org/r/57166/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message