mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 56901: Updated master validation code to use the 'Principal' type.
Date Fri, 03 Mar 2017 23:35:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56901/#review167895
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On March 3, 2017, 6:41 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56901/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 6:41 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and
Vinod Kone.
> 
> 
> Bugs: MESOS-7003
>     https://issues.apache.org/jira/browse/MESOS-7003
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates master validation code to
> make use of the `Principal` type instead of an
> `Option<string> principal`.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp 50a3e6ec6a6d44c9ad449edfbd5d2cf8540b3a73 
>   src/master/validation.cpp 41ef0d072ca53d9695c16b8dd98c319186f11f75 
> 
> 
> Diff: https://reviews.apache.org/r/56901/diff/4/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message