mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 56621: Updated Mesos tests to use the 'Principal' type.
Date Sat, 04 Mar 2017 00:36:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56621/#review167911
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On March 3, 2017, 6:51 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56621/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 6:51 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and
Vinod Kone.
> 
> 
> Bugs: MESOS-7003
>     https://issues.apache.org/jira/browse/MESOS-7003
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the Mesos tests to use authenticated
> handlers which accept the `Principal` type instead of an
> `Option<string> principal`.
> 
> 
> Diffs
> -----
> 
>   src/tests/files_tests.cpp 6c6353e406249f021803e83909415e9908ded28c 
>   src/tests/http_authentication_tests.cpp 95f01c432f77d1a944dd78c343e21b310676417f 
>   src/tests/master_validation_tests.cpp 5a84c8d03cacd150ac61213a7c2d8613fd1780e7 
> 
> 
> Diff: https://reviews.apache.org/r/56621/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message