mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 57158: Added default parameter value to master validation function.
Date Sat, 04 Mar 2017 00:37:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57158/#review167912
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On March 3, 2017, 6:52 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57158/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 6:52 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master's validation function for RESERVE operations previously
> did not set a default parameter value for its final optional
> parameter, requiring callsites to explicitly specify `None()`. This
> patch adds the default value.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 37b96c07f17d3e5ba96f6eade69d86ba9e039b3d 
>   src/master/validation.hpp 50a3e6ec6a6d44c9ad449edfbd5d2cf8540b3a73 
> 
> 
> Diff: https://reviews.apache.org/r/57158/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message