mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.
Date Mon, 06 Mar 2017 19:10:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54449/
-----------------------------------------------------------

(Updated March 6, 2017, 7:10 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
-------

Rebase and address review feedback.


Bugs: MESOS-6732
    https://issues.apache.org/jira/browse/MESOS-6732


Repository: mesos


Description
-------

The XFS disk isolator checks that the filesystem is XFS, but doesn't
check whether project quotas are actually enabled. This means that
an invalid configuration will start but will always fail when tasks
are launched.

Add a check to test whether project quotas are enabled on the work
directory and fail hard if they are not.


Diffs (updated)
-----

  configure.ac 1e47babefa9ebd7e6fa3c23e8cb0e88bee16c671 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp dd4df86bf90bfa9cbf4664d89274cf3c64c2e374

  src/slave/containerizer/mesos/isolators/xfs/utils.hpp 7602fe3b6ab069db643397418732e773d0417f8a

  src/slave/containerizer/mesos/isolators/xfs/utils.cpp b9d8e7dc999ba3064bee7105eff0f9553d825df8

  src/tests/containerizer/xfs_quota_tests.cpp 0fbaddd68af55c51c106962377be20afa599fb97 


Diff: https://reviews.apache.org/r/54449/diff/4/

Changes: https://reviews.apache.org/r/54449/diff/3-4/


Testing
-------

Make check on Fedora 25. Manual test on F25 with mesos-execute.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message