mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56754: Implemented a JWT secret generator.
Date Tue, 07 Mar 2017 19:55:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56754/#review168175
-----------------------------------------------------------


Fix it, then Ship it!




Looking good! Just a few small comments below.


src/tests/secret_generator_tests.cpp
Lines 55 (patched)
<https://reviews.apache.org/r/56754/#comment240335>

    Is the `Option<string>::none()` necessary? I think the `value` member would be default-initialized
to `NONE`?



src/tests/secret_generator_tests.cpp
Lines 63-66 (patched)
<https://reviews.apache.org/r/56754/#comment240337>

    s/token.get()/token->/



src/tests/secret_generator_tests.cpp
Lines 68 (patched)
<https://reviews.apache.org/r/56754/#comment240338>

    Could use EXPECT_SOME here.



src/tests/secret_generator_tests.cpp
Lines 72-73 (patched)
<https://reviews.apache.org/r/56754/#comment240339>

    I think the `EXPECT_SOME` here is redundant since you're using `EXPECT_SOME_EQ`?



src/tests/secret_generator_tests.cpp
Lines 77-78 (patched)
<https://reviews.apache.org/r/56754/#comment240340>

    Ditto.


- Greg Mann


On March 7, 2017, 3:40 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56754/
> -----------------------------------------------------------
> 
> (Updated March 7, 2017, 3:40 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-7000
>     https://issues.apache.org/jira/browse/MESOS-7000
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This can be used to create a 'Secret' from a 'Principal'.
> The resulting secret will provide a JWT.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am bb917c5d1b36f5106a74914fa3a864038a95e8bb 
>   src/authentication/executor/jwt_secret_generator.hpp PRE-CREATION 
>   src/authentication/executor/jwt_secret_generator.cpp PRE-CREATION 
>   src/tests/secret_generator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56754/diff/7/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message