mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 57384: Added `Containerizer::cleanupArtifacts`.
Date Thu, 09 Mar 2017 01:01:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57384/#review168385
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp
Lines 2483 (patched)
<https://reviews.apache.org/r/57384/#comment240621>

    s/check/Check/



src/slave/containerizer/mesos/containerizer.cpp
Lines 2496 (patched)
<https://reviews.apache.org/r/57384/#comment240622>

    Does a parent container's destruction imply removal of sandbox and runtime directories
of itself and/or all its children?



src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 2077 (patched)
<https://reviews.apache.org/r/57384/#comment240623>

    Can you add a test where you call delete of nested container after parent container has
exited?


- Vinod Kone


On March 8, 2017, 10:50 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57384/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 10:50 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7120
>     https://issues.apache.org/jira/browse/MESOS-7120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This new method cleans up the sandbox and runtime directories of a
> terminated nested container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.hpp f65a9b9761fc254bd0778bf13aac9b256497b22f

>   src/slave/containerizer/mesos/containerizer.hpp 09f94ccb3224c14a9324961b789455b119ec2257

>   src/slave/containerizer/mesos/containerizer.cpp b001d0265ec73822193eaac74c631930acce90c0

>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c

> 
> 
> Diff: https://reviews.apache.org/r/57384/diff/2/
> 
> 
> Testing
> -------
> 
> Added a test and verified that it works on Linux.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message