mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 57260: CMake: Refactored FindApr.cmake and FindSvn.cmake.
Date Thu, 09 Mar 2017 10:06:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57260/#review168425
-----------------------------------------------------------



Upstream since some time provides find modules for openssl, subversion and CURL, so I wonder
whether we currently even need to generalize this. Are the upstream modules broken in certain
cmake versions (if yes, we should add notes)?

- Benjamin Bannier


On March 3, 2017, 12:53 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57260/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 12:53 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Alex Clemmer, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-6691
>     https://issues.apache.org/jira/browse/MESOS-6691
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The logic to find APR and SVN headers/libraries are effectively the
> same, except for where those headers/libraries might be found.
> 
> This commit refactors the two files into a helper that takes several
> lists as arguments (lists are passed by reference in CMake) and
> outputs two lists of directories.
> 
> This also removes the logic for finding `APR-util`, which is not
> used in this project.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/FindApr.cmake 13156a58a57c22044977c7220df31372e61f82f6 
>   3rdparty/stout/cmake/FindPackageHelper.cmake PRE-CREATION 
>   3rdparty/stout/cmake/FindSvn.cmake d57eed98285295bcc845bb0494c86e3866685690 
> 
> 
> Diff: https://reviews.apache.org/r/57260/diff/1/
> 
> 
> Testing
> -------
> 
> cmake ..
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message