mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 57387: Implemented the Agent API call `DeleteNestedContainer`.
Date Thu, 09 Mar 2017 14:32:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57387/#review168450
-----------------------------------------------------------


Ship it!





src/slave/http.cpp
Lines 2464-2471 (patched)
<https://reviews.apache.org/r/57387/#comment240718>

    More of a note to self, this snippet appears over and over, perhaps we can create a function:
`getApprover(subject, action)` or perhaps an:
    `approve(subject, action, callback)` which does up to the `return approver.then(defer(slave->self(),
callback())`.


- Alexander Rojas


On March 7, 2017, 6:17 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57387/
> -----------------------------------------------------------
> 
> (Updated March 7, 2017, 6:17 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Jie Yu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7120
>     https://issues.apache.org/jira/browse/MESOS-7120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This new Agent API call makes it possible to destroy the sandbox and
> runtime directories of a terminated nested container.
> 
> 
> Diffs
> -----
> 
>   src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22 
>   src/slave/http.cpp bc8209cb81194ebc8b604c9ba0d4a9e176cff2f6 
>   src/slave/slave.hpp 978edd6309dfbbde1058f9c44d5fac7083ff95fb 
>   src/slave/validation.cpp 3dbd0fa6ec27b38f40c7922c256859b4d29059ac 
>   src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
>   src/tests/slave_validation_tests.cpp 784528443469f68a8f2d93ebdb69dc872eef255d 
> 
> 
> Diff: https://reviews.apache.org/r/57387/diff/2/
> 
> 
> Testing
> -------
> 
> The patch contains validation and auth tests that pass on Linux.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message