mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 57167: Updated quota handler logic for hierarchical roles.
Date Thu, 09 Mar 2017 16:44:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57167/
-----------------------------------------------------------

(Updated March 9, 2017, 4:44 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Introduce `QuotaTree`, other fixes.


Repository: mesos


Description (updated)
-------

The quota'd resources for a nested role are "included" within the
quota'd resources for that role's parent. Hence, the quota of a node
must always be greater than or equal to the sum of the quota'd resources
of that role's children.

When creating and removing quota, we must ensure that this invariant is
not violated.

When computing the cluster capacity heuristic, we must ensure that we do
not "double-count" quota'd resources: e.g., if the cluster has a total
capacity of 100 CPUs, role "x" has a quota guarantee of 80 CPUs, and
role "x/y" has a quota guarantee of 40 CPUs, this does NOT violate the
cluster capacity heuristic.


Diffs (updated)
-----

  src/master/quota_handler.cpp ce1f0644a56e85a99d8c3742d00940a1bfae3be3 
  src/tests/hierarchical_allocator_tests.cpp cdf1f15b7802439b28405ca8f6634ce83e886630 
  src/tests/master_quota_tests.cpp e109656492bc5ac65e398b6b61e7321072b162d3 


Diff: https://reviews.apache.org/r/57167/diff/2/

Changes: https://reviews.apache.org/r/57167/diff/1-2/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message