mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 57260: CMake: Refactored FindApr.cmake and FindSvn.cmake.
Date Thu, 09 Mar 2017 19:09:33 GMT


> On March 9, 2017, 2:06 a.m., Benjamin Bannier wrote:
> > Upstream since some time provides find modules for openssl, subversion and CURL,
so I wonder whether we currently even need to generalize this. Are the upstream modules broken
in certain cmake versions (if yes, we should add notes)?

Several points to make:

* CMake 2.8.10 (the earliest supported version) does not have a `FindAPR.cmake` file, but
it does have this `FindSubversion.cmake` file.  However, this finds the *executable* and not
the library: https://github.com/Kitware/CMake/blob/v2.8.10/Modules/FindSubversion.cmake
* We may need to specialize this at some point in order to support building against other
installations of these libraries (i.e. autotools' --with_ssl=... config option).  The CMake
provided modules are somewhat inconsistent in the options they provide.  Some of them are
configurable, some of them aren't.
* We currently don't use the results of `find_package(curl)`.  So I will remove that line
and the custom `FindCurl.cmake` file.  We can use the CMake one anyway: https://github.com/Kitware/CMake/blob/v2.8.10/Modules/FindCURL.cmake
* I'll replace part of the last patch in the chain with this instead: https://github.com/Kitware/CMake/blob/v2.8.10/Modules/FindOpenSSL.cmake


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57260/#review168425
-----------------------------------------------------------


On March 2, 2017, 3:53 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57260/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 3:53 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Alex Clemmer, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-6691
>     https://issues.apache.org/jira/browse/MESOS-6691
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The logic to find APR and SVN headers/libraries are effectively the
> same, except for where those headers/libraries might be found.
> 
> This commit refactors the two files into a helper that takes several
> lists as arguments (lists are passed by reference in CMake) and
> outputs two lists of directories.
> 
> This also removes the logic for finding `APR-util`, which is not
> used in this project.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/FindApr.cmake 13156a58a57c22044977c7220df31372e61f82f6 
>   3rdparty/stout/cmake/FindPackageHelper.cmake PRE-CREATION 
>   3rdparty/stout/cmake/FindSvn.cmake d57eed98285295bcc845bb0494c86e3866685690 
> 
> 
> Diff: https://reviews.apache.org/r/57260/diff/1/
> 
> 
> Testing
> -------
> 
> cmake ..
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message