mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 57480: Replaced an instance of `/dev/null` with `os::DEV_NULL`.
Date Thu, 09 Mar 2017 22:23:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57480/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and Alex Clemmer.


Repository: mesos


Description
-------

`os::DEV_NULL` is a constant defined in stout that points to `/dev/null`
on Posix and `NUL` on Windows.  The two locations behave similarly
on their respective platforms.

This change future-proofs this code on Windows (only fails at runtime)
in case the related features are added to the Windows build.


Diffs
-----

  3rdparty/libprocess/src/io.cpp be41e7fc7727512d5201b8e059f5b61c31ff88ef 


Diff: https://reviews.apache.org/r/57480/diff/1/


Testing
-------

See next review.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message