mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 56730: Kill stray tasks when tearing down test cgroups.
Date Thu, 09 Mar 2017 22:33:32 GMT


> On March 9, 2017, 1:32 p.m., Jiang Yan Xu wrote:
> > It could be a follow up patch or a TODO but given the possibility of uninterruptable
processes etc. We can further reduce the chance of destroy failure by starting the cleanup
with the freezer subsystem first if it's in the list of `subsystems` right? I understand this
is not bullet proof either (the test may not be in the freezer cgroups that are are cleaning
up considering arbitrary test failures) but a further improvement nonetheless?
> 
> James Peach wrote:
>     Using the freezer could make teardown more reliable, depending on how long the task
is uninterruptible for. I expect that getting stuck in an uninterruptible state is rare enough
that it deserves investigation.

Committed. "stuck" case would also fail the timeout on `AWAIT_READY(cgroups::destory())`,
which may be the sufficiently interesting case to investigate. Not sure about transient uninterruptable
cases. Anyhow this is "just test teardown"; let's see if this is an issue.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56730/#review168417
-----------------------------------------------------------


On March 8, 2017, 4:03 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56730/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 4:03 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7049
>     https://issues.apache.org/jira/browse/MESOS-7049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a test case fails, it may leave stray tasks in the cgroup which keeps
> us from tearing it down when the test completes. Kill any stray tasks
> before destroying the cgroup.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_tests.cpp 76fabce4530ccc0a1d685cd48d932ced5a64bc58

>   src/tests/mesos.cpp 6a96fa51dfc2a62063c3154b256bdac707b009bb 
> 
> 
> Diff: https://reviews.apache.org/r/56730/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message