mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.
Date Thu, 09 Mar 2017 23:46:36 GMT


> On Feb. 13, 2017, 2:31 p.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/src/tests/http_tests.cpp
> > Lines 1860-1863 (patched)
> > <https://reviews.apache.org/r/56475/diff/1/?file=1628066#file1628066line1860>
> >
> >     Probably create the expected value in a variable outside of the `EXPECT_EQ`?

No longer applicable, so dropping.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56475/#review165326
-----------------------------------------------------------


On March 9, 2017, 11:45 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56475/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 11:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a unit test to verify the functionality of
> the `CombinedAuthenticator`. The new test is called
> 'CombinedAuthenticatorTest.MultipleAuthenticators'.
> 
> 
> Diffs
> -----
> 
>   src/tests/http_authentication_tests.cpp d5fabf0058755502f19eb6385bd99a0d45419508 
> 
> 
> Diff: https://reviews.apache.org/r/56475/diff/2/
> 
> 
> Testing
> -------
> 
> The following commands were used to test:
> `make check`
> `3rdparty/libprocess/libprocess-tests --gtest_filter="*MultipleAuthenticators*" --gtest_repeat=10000`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message