mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.
Date Fri, 10 Mar 2017 01:16:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54449/
-----------------------------------------------------------

(Updated March 10, 2017, 1:16 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
-------

Addressed review feedback.


Bugs: MESOS-6732
    https://issues.apache.org/jira/browse/MESOS-6732


Repository: mesos


Description
-------

The XFS disk isolator checks that the filesystem is XFS, but doesn't
check whether project quotas are actually enabled. This means that
an invalid configuration will start but will always fail when tasks
are launched.

Add a check to test whether project quotas are enabled on the work
directory and fail hard if they are not.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/authenticator.hpp 00660f42cd4b707d955745bbfea5ffec73f690d6

  3rdparty/libprocess/include/process/http.hpp 9b89d31d60f7977f30f623a7315e67f97f5940e7 
  3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5

  3rdparty/libprocess/include/process/metrics/metrics.hpp 9c32a88d851c884a5025edb6ea1e27939b484546

  3rdparty/libprocess/include/process/process.hpp 401510c8f7b7d546d5364756dcab3245207ca5ab

  3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0

  3rdparty/libprocess/src/authenticator.cpp 8d1756f0a2e124440bc7c69a1b25576f607c2d03 
  3rdparty/libprocess/src/authenticator_manager.cpp 5cbed53e7085f227d90679e1b56ad803d9b74a47

  3rdparty/libprocess/src/logging.cpp cfaf1793dfcb404448319c1eddd7a971b3374296 
  3rdparty/libprocess/src/metrics/metrics.cpp 7184aa4d0294c20466646c9aa61d90973eca22e1 
  3rdparty/libprocess/src/process.cpp 9eb7fe3d20aa9416db5162fa275fcf116f5d6477 
  3rdparty/libprocess/src/profiler.cpp a29e8d1e18136ec2b88cce19f03ee3073f8d6340 
  3rdparty/libprocess/src/tests/http_tests.cpp a0e23c2300f9f6b9d1143ee1eb115bbf24adf92e 
  configure.ac 1e47babefa9ebd7e6fa3c23e8cb0e88bee16c671 
  include/mesos/agent/agent.proto 9149724159485ea2265e1494c1ce7ef989dad20a 
  include/mesos/authorizer/authorizer.proto fdc4817ce74c45d792fc47f064f7909a83b1657d 
  include/mesos/v1/agent/agent.proto 34210c30ca58f50b14ff3e5a01c54003c9705121 
  src/common/http.hpp a3cfc5d8f0b2e453d5f6c3e485e92dbd643737a3 
  src/common/http.cpp 0848f70ad4fa9e67c74c9fbdd882d7ab5ed6eabf 
  src/files/files.hpp 1e123fac21ab98c508ca96112e080bd7d48389cb 
  src/files/files.cpp f066146b7cbff35c452717d179b79039bc603cc8 
  src/master/allocator/mesos/hierarchical.hpp 646f66e67d9c6b8c61fc6e6558a1db976a44c126 
  src/master/allocator/mesos/hierarchical.cpp 0059ccead90f32491591990c791e7fa905a864b7 
  src/master/http.cpp de2cc03e6c7a3b75224113f56ce268937ead2929 
  src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
  src/master/master.cpp dd1e4cd7c2da32949ffc69ce4f7b169b153fc736 
  src/master/quota_handler.cpp ce1f0644a56e85a99d8c3742d00940a1bfae3be3 
  src/master/registrar.cpp 0029cc77628b5bb2a7b1ff551fb42b3eaf7b4fb1 
  src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e 
  src/master/validation.cpp 3f70875484bbd856ac79a7d6070ac313d69782fa 
  src/master/weights_handler.cpp a4d2fed758878f3e2b9557a61965816aa9e0399c 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp dd4df86bf90bfa9cbf4664d89274cf3c64c2e374

  src/slave/containerizer/mesos/isolators/xfs/utils.hpp 7602fe3b6ab069db643397418732e773d0417f8a

  src/slave/containerizer/mesos/isolators/xfs/utils.cpp b9d8e7dc999ba3064bee7105eff0f9553d825df8

  src/slave/http.cpp bc8209cb81194ebc8b604c9ba0d4a9e176cff2f6 
  src/slave/slave.hpp 978edd6309dfbbde1058f9c44d5fac7083ff95fb 
  src/slave/slave.cpp 4319f841fbdc7ad39eb60eb52ae2a764b133cfbd 
  src/slave/validation.cpp 3dbd0fa6ec27b38f40c7922c256859b4d29059ac 
  src/tests/api_tests.cpp 52f58a4d6b1ea75744de1c3d2f0f064d9299fe1d 
  src/tests/containerizer/runtime_isolator_tests.cpp fbca31a4da1c83574cce7414fe5e03b1f86591cb

  src/tests/containerizer/xfs_quota_tests.cpp 0fbaddd68af55c51c106962377be20afa599fb97 
  src/tests/default_executor_tests.cpp e4d43c8ad447577a9c5c7951207596bda1070856 
  src/tests/files_tests.cpp d492adf71ecb22c433f0eba4d974e99f610b5dd3 
  src/tests/http_authentication_tests.cpp d5fabf0058755502f19eb6385bd99a0d45419508 
  src/tests/master_validation_tests.cpp 11dfbc612ee2c9a39a17dc1ca9bde04eeb65b550 
  src/tests/mesos.hpp f39e243c2c11bc1c9c757049fda2122727d1fef9 


Diff: https://reviews.apache.org/r/54449/diff/5/

Changes: https://reviews.apache.org/r/54449/diff/4-5/


Testing
-------

Make check on Fedora 25. Manual test on F25 with mesos-execute.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message