mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 57481: Replaced most instances of `/dev/null` with `os::DEV_NULL`.
Date Fri, 10 Mar 2017 09:42:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57481/#review168591
-----------------------------------------------------------



Patch looks great!

Reviews applied: [55022, 55023, 55024, 55030, 55162, 55543, 55546, 57480, 57481]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 9, 2017, 11:24 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57481/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 11:24 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Alex Clemmer.
> 
> 
> Bugs: MESOS-3098
>     https://issues.apache.org/jira/browse/MESOS-3098
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `os::DEV_NULL` is a constant defined in stout that points to `/dev/null`
> on Posix and `NUL` on Windows.  The two locations behave similarly
> on their respective platforms.
> 
> This change future-proofs this code on Windows (only fails at runtime)
> in case the related features are added or enabled on the Windows build.
> 
> This change leaves some `/dev/null` strings in tests alone, in
> tests that use other `/dev` files, like `/dev/zero`.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1 
>   src/common/command_utils.cpp 09e805140d95af817c314e38128215f3a8e5ab91 
>   src/docker/docker.cpp 634ab40be0ca1e4cb4340b78eec2ae9a1fd48b25 
>   src/hdfs/hdfs.cpp 4aea868b25a878efc280f8d85a03a2b9d799f495 
>   src/launcher/fetcher.cpp 362ad065c5b7e9a858471ce44d94d7399f867cf2 
>   src/slave/container_loggers/lib_logrotate.hpp 561ddb6a8274307f1830274a36327eaa4519c76d

>   src/slave/container_loggers/lib_logrotate.cpp acaad384cf1a9681659eaaab18a9c942f6b7e1d9

>   src/slave/container_loggers/logrotate.hpp 1fce8e3528e55aff798fbbf056bf6d9ed2142255

>   src/slave/containerizer/mesos/io/switchboard.cpp 27395f9c69a82590fbf5243db6aef436a6f98479

>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp cf0466c625c082e1f1841086d56270c824febfb5

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 84dc157e7d9e332a6da0f1fc33303e9ef9bdc147

>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 4ecc4aaeec8abb8e44f9fb6a1846f1c66a15246d

>   src/slave/containerizer/mesos/isolators/posix/disk.cpp db05833869a8f8a7582f9415066268de6face295

>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 0ce3e1eb16f1b82e02d360f9e6aef6d5dc979010

>   src/tests/command_executor_tests.cpp de735c62ae4be268b3e37d636f43f120f879a624 
>   src/tests/container_logger_tests.cpp 54e5b29ce0668449027bde6185e37dc8b636d8c7 
>   src/tests/containerizer/cgroups_tests.cpp 76fabce4530ccc0a1d685cd48d932ced5a64bc58

>   src/tests/containerizer/docker_tests.cpp 452858d508e668fe62826de5558ea332cd4279d5 
>   src/tests/containerizer/io_switchboard_tests.cpp 9031815f5711cf940315ab3d8538aa099b356847

>   src/tests/containerizer/port_mapping_tests.cpp 3e848165ace8346ead39224a46f8b85a5c4ff495

>   src/tests/containerizer/xfs_quota_tests.cpp 0fbaddd68af55c51c106962377be20afa599fb97

>   src/tests/script.cpp deec24886526a3a8355ec7cd863ca2236fae5829 
>   src/tests/uri_fetcher_tests.cpp 40bec5bafb49afef5b127456fbb4064be114f409 
>   src/uri/fetchers/copy.cpp 2cfef5ab0ad76a488c47a23258defce1d9820d07 
>   src/uri/fetchers/curl.cpp 7b746d619755db59903b44147926d28bb2b7f130 
>   src/uri/fetchers/docker.cpp 68f380dd17496ad5100e4d57cebd80f1edb6ed14 
> 
> 
> Diff: https://reviews.apache.org/r/57481/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message