mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 56474: Added the 'CombinedAuthenticator'.
Date Fri, 10 Mar 2017 12:50:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56474/#review168602
-----------------------------------------------------------




include/mesos/authentication/http/combined_authenticator.hpp
Lines 61 (patched)
<https://reviews.apache.org/r/56474/#comment240863>

    Add on `override`, the destructor should be virtual when inheriting.



src/authentication/http/combined_authenticator.cpp
Lines 20 (patched)
<https://reviews.apache.org/r/56474/#comment240860>

    Include before `<string>.



src/authentication/http/combined_authenticator.cpp
Lines 71 (patched)
<https://reviews.apache.org/r/56474/#comment240859>

    This function is neither used nor implemented. This definition can be removed.



src/authentication/http/combined_authenticator.cpp
Lines 106 (patched)
<https://reviews.apache.org/r/56474/#comment240861>

    If, at this point, `combinedUnauthorized` didn't have a `WWW-Authenticate` header yet,
this will result in
    the header value starting with a comma, e.g.
    ```
    WWW-Authenticate: ,Basic realm=foo
    ```



src/authentication/http/combined_authenticator.cpp
Lines 172 (patched)
<https://reviews.apache.org/r/56474/#comment240862>

    Is it okay to capture `this` here? I just remembered (MESOS-5629)[https://issues.apache.org/jira/browse/MESOS-5629]
but didn't closely follow the discussion. Feel free to drop this one, if the capture isn't
an issue.


- Jan Schlicht


On March 10, 2017, 1:33 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56474/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 1:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new default authenticator, the
> `CombinedAuthenticator`, which can load multiple authenticators.
> It calls installed authenticators serially, returning the first
> successful result. When no results are successful, it returns a
> single result obtained by merging all unsuccessful results.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/combined_authenticator.hpp PRE-CREATION 
>   src/Makefile.am bb917c5d1b36f5106a74914fa3a864038a95e8bb 
>   src/authentication/http/combined_authenticator.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56474/diff/4/
> 
> 
> Testing
> -------
> 
> Testing information can be found in the subsequent patch in this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message