mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 56667: Added support for JSON Web Tokens.
Date Fri, 10 Mar 2017 12:56:12 GMT


> On March 8, 2017, 8:43 p.m., Greg Mann wrote:
> > 3rdparty/libprocess/src/jwt.cpp
> > Lines 168-170 (patched)
> > <https://reviews.apache.org/r/56667/diff/8/?file=1659260#file1659260line168>
> >
> >     If you want to improve the encapsulation of the error messages a bit, you could
prefix with "Parsing token header failed: " here, and remove specific references to the header
from the error messages returned by `parse_header`. Could do a similar thing with `parse_payload`.
Up to you.

IMO it's okay as it is right now because the helper functions are only used in this compilation
unit. Would add that encapsulation if this wasn't the case though. Dropping this one.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56667/#review168328
-----------------------------------------------------------


On March 9, 2017, 3:47 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56667/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 3:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-7001
>     https://issues.apache.org/jira/browse/MESOS-7001
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> JSON Web Tokens can be used to create claim-based access tokens and is
> typically used for HTTP authentication.
> This implementation is intended for internal use, e.g. Mesos is supposed
> to only parse tokens that it also created. It doesn't fully comply with
> RFC 7519. Currently the only supported cryptographic algorithm is HMAC
> with SHA-256.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c 
>   3rdparty/libprocess/include/process/jwt.hpp PRE-CREATION 
>   3rdparty/libprocess/src/jwt.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/jwt_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56667/diff/9/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message