mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor.
Date Wed, 15 Mar 2017 09:51:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57596/#review168976
-----------------------------------------------------------




src/launcher/executor.cpp
Line 383 (original), 383 (patched)
<https://reviews.apache.org/r/57596/#comment241314>

    i would rather use `_task` here and below because it gets harder to see that `taskData.taskInfo`
is `Some` the deeper you go into this function.



src/launcher/executor.cpp
Lines 886 (patched)
<https://reviews.apache.org/r/57596/#comment241315>

    Add a comment to signify what this boolean captures.



src/launcher/executor.cpp
Lines 887 (patched)
<https://reviews.apache.org/r/57596/#comment241316>

    since `acknowledged` doesn't make sense without `taskInfo`, I would make `taskInfo` non-optional
and make `taskData` optional.


- Vinod Kone


On March 14, 2017, 2:08 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57596/
> -----------------------------------------------------------
> 
> (Updated March 14, 2017, 2:08 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prior to this patch, command executor wipes TaskInfo after receiving
> a status update acknowledgement from the scheduler to indicate that
> there are no unacknowledged tasks. Keeping original TaskInfo beyond
> the ack can be beneficial, hence we introduce a struct TaskData that
> holds TaskInfo and explicit ack flag.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378 
> 
> 
> Diff: https://reviews.apache.org/r/57596/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56213/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message