mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 57425: Added pull method to Containerizer.
Date Wed, 15 Mar 2017 10:41:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57425/
-----------------------------------------------------------

(Updated March 15, 2017, 10:41 a.m.)


Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-2824
    https://issues.apache.org/jira/browse/MESOS-2824


Repository: mesos


Description
-------

New method is intended to be called by the agent for pulling container
image when asked by an operator.

Currently implemented only for MesosContainerizer.


Diffs (updated)
-----

  src/slave/containerizer/containerizer.hpp 4c31a1f5c853c1dc66480c7b4c867a87a1bb5c41 
  src/slave/containerizer/containerizer.cpp 9024371b6c4228f0903cfeef3bbec736e1a425f8 
  src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d

  src/slave/containerizer/mesos/containerizer.cpp 12cf1d8b2872ee3ba25c893d5553eaff048eccac

  src/slave/containerizer/mesos/provisioner/provisioner.hpp 7d6c1b93a2c0e265b9344a0fc27f1cf4ed5325f2

  src/slave/containerizer/mesos/provisioner/provisioner.cpp 478ab09751bbb96c8815c021bc818833b96596b0

  src/tests/containerizer.hpp 63fe2366d5fe79c71cbe62813a9bb0b830e70057 
  src/tests/containerizer.cpp 548da3a8757c9ad3ab115c6b91f8a1f2f5e37144 
  src/tests/containerizer/mesos_containerizer_tests.cpp ec9f354c8cb6735f319b7dbea2465a31f3a8d64d



Diff: https://reviews.apache.org/r/57425/diff/2/

Changes: https://reviews.apache.org/r/57425/diff/1-2/


Testing
-------

Added `MesosContainerizerProvisionerTest.PullImage` test verifying that `MesosContainerizer`
calls the required `Store` method. Ran `make check`.


Thanks,

Ilya Pronin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message