mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 55790: Support the full CNI DNS specification.
Date Thu, 16 Mar 2017 01:26:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55790/#review169089
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Line 986 (original), 979 (patched)
<https://reviews.apache.org/r/55790/#comment241411>

    Can you follow up with a patch to document this?



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Lines 999 (patched)
<https://reviews.apache.org/r/55790/#comment241410>

    Why do you need this?



src/tests/containerizer/cni_isolator_tests.cpp
Lines 152-154 (patched)
<https://reviews.apache.org/r/55790/#comment241412>

    We typically combine these two:
    ```
    Try<Nothing> result = os::mkdir(cniPluginDir);
    ```



src/tests/containerizer/cni_isolator_tests.cpp
Lines 167-168 (patched)
<https://reviews.apache.org/r/55790/#comment241413>

    I would adjust the indentation here:
    ```
    result = os::chmod(
        mockPlugin,
        S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH);
    ```



src/tests/containerizer/cni_isolator_tests.cpp
Lines 1204 (patched)
<https://reviews.apache.org/r/55790/#comment241414>

    I would rename this to CniSpecTest.GenerateResolverConfig


- Jie Yu


On March 7, 2017, 5:01 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55790/
> -----------------------------------------------------------
> 
> (Updated March 7, 2017, 5:01 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6858
>     https://issues.apache.org/jira/browse/MESOS-6858
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add support for the full set of DNS resolver configuration items that
> a CNI IPAM plugin can specify. This implements updating the container's
> resolv.conf with the 'domain', 'search', and 'options' keywords.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 84dc157e7d9e332a6da0f1fc33303e9ef9bdc147

>   src/slave/containerizer/mesos/isolators/network/cni/spec.hpp ccd511ec14810dcc1020dec5e1641141f3a319b4

>   src/slave/containerizer/mesos/isolators/network/cni/spec.cpp ac48159dadcea422f605e723db94a7f3bb573fa2

>   src/tests/containerizer/cni_isolator_tests.cpp cb893d3ef005a9cc60c40768fa669b27c4863020

> 
> 
> Diff: https://reviews.apache.org/r/55790/diff/5/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message