-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/#review169359
-----------------------------------------------------------
src/webui/master/static/roles.html
Lines 28-31 (patched)
<https://reviews.apache.org/r/57622/#comment241713>
I change to
```
- <td>{{role.resources.cpus | number}}</td>
- <td>{{role.resources.gpus | number}}</td>
- <td>{{role.resources.mem * (1024 * 1024) | number}}</td>
- <td>{{role.resources.disk * (1024 * 1024) | number}}</td>
+ <td>{{role.resources.cpus | decimalFloat}}</td>
+ <td>{{role.resources.gpus | decimalFloat}}</td>
+ <td>{{role.resources.mem * (1024 * 1024) | dataSize}}</td>
+ <td>{{role.resources.disk * (1024 * 1024) | dataSize}}</td>
```
here
- haosdent huang
On March 16, 2017, 1:28 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57622/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 1:28 a.m.)
>
>
> Review request for mesos, Jay Guo, haosdent huang, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-6995
> https://issues.apache.org/jira/browse/MESOS-6995
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Initially, this includes the weight, number of frameworks involved
> with the role, and the resource allocation. Longer term this should
> include the quota information and the revocable resources.
>
>
> Diffs
> -----
>
> src/Makefile.am 8c67e472ec2e973b66c0004f6bf58bd8b0e4fad3
> src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83
> src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6
> src/webui/master/static/js/controllers.js ae3e7875258fed9e70b8d15ac82b3e8ffadc6522
> src/webui/master/static/roles.html PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57622/diff/4/
>
>
> Testing
> -------
>
> manual testing.
>
>
> File Attachments
> ----------------
>
> screenshot
> https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png
>
>
> Thanks,
>
> Benjamin Mahler
>
>
|