mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 57748: Enabled executor authentication in the tests.
Date Fri, 24 Mar 2017 04:52:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57748/#review169976
-----------------------------------------------------------




src/tests/cluster.hpp
Lines 226 (patched)
<https://reviews.apache.org/r/57748/#comment242697>

    Why this change?



src/tests/mesos.cpp
Lines 211 (patched)
<https://reviews.apache.org/r/57748/#comment242699>

    Can you add a comment here for posterity that these statements are needed for enabling
executor AuthN?


- Anand Mazumdar


On March 22, 2017, 2:47 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57748/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 2:47 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch sets the `--authenticate_http_executors` and
> `--executor_secret_key` flags by default in the tests,
> and it updates the test cluster code to load a secret
> generator when those flags are set.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.hpp 250b12fcffd035834817ff6060eb80c2cf3e0246 
>   src/tests/cluster.cpp 15eaf4241873dc86281627db1002f9aadd26e6dc 
>   src/tests/mesos.cpp 3333c507b86075f1c24afed3fedf3e8371464d82 
> 
> 
> Diff: https://reviews.apache.org/r/57748/diff/3/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message