mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 57750: Turned off executor authentication in the ExecutorHttpApiTests.
Date Fri, 24 Mar 2017 05:22:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57750/#review169978
-----------------------------------------------------------




src/tests/executor_http_api_tests.cpp
Lines 90 (patched)
<https://reviews.apache.org/r/57750/#comment242700>

    Why not create a virtual overload named `CreateSlaveFlags`?
    
    There should already be other text fixtures doing the same.



src/tests/executor_http_api_tests.cpp
Lines 369 (patched)
<https://reviews.apache.org/r/57750/#comment242701>

    Move this after L374 closer to where it's used?


- Anand Mazumdar


On March 23, 2017, 4:16 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57750/
> -----------------------------------------------------------
> 
> (Updated March 23, 2017, 4:16 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch turns off executor authentication in the
> ExecutorHttpApiTests, since authentication is not related
> to the functionality they are meant to test. Since executor
> tokens depend on the FrameworkID/ExecutorID/ContainerID of
> the executor, it would be difficult to enable it in these
> tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/executor_http_api_tests.cpp 13d2e1db2ffdad34dadbf2911e91938706fd4fd0 
> 
> 
> Diff: https://reviews.apache.org/r/57750/diff/5/
> 
> 
> Testing
> -------
> 
> `make check` was done to test that all existing tests succeed when executor authentication
is enabled by default in the test cluster code. The ExecutorHttpApiTests are the only tests
in which it has been disabled.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message