mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 57860: Docker environment gets passed on docker run command.
Date Fri, 24 Mar 2017 05:51:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57860/#review169980
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On March 24, 2017, 5:08 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57860/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 5:08 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Gilbert Song, James DeFelice,
Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-6951
>     https://issues.apache.org/jira/browse/MESOS-6951
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removes the use of --env_file as that does not support newlines
> in environment variable values. Also avoids leaking of possibly
> sensitive environment variables to the log.
> 
> Manually backported for 1.2.x.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 68042fd6f3b19c12cddd0d2e74ae064ceceb6a8c 
> 
> 
> Diff: https://reviews.apache.org/r/57860/diff/4/
> 
> 
> Testing
> -------
> 
> make check & sudo ./bin/mesos-tests.sh
> 
> Functional testing.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message