mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 57923: Changed the agent's SecretGenerator from Owned to pointer.
Date Fri, 24 Mar 2017 21:50:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 24, 2017, 9:50 p.m.)

Review request for mesos, Anand Mazumdar and Vinod Kone.


Added nullptr initialization.

Bugs: MESOS-6999

Repository: mesos


This patch updates the agent to hold its `SecretGenerator` as a
raw pointer instead of an `Owned` object. This is more consistent
with the other dependencies injected into the agent, and makes it
easier to test the agent with a mock secret generator.

Diffs (updated)

  src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb 
  src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b 




Testing details can be found at the end of this patch chain.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message